Don't add parameters changes to browser's history

getredash · Jan 20, 2020 · f8e7334 · f8e7334
1 parent 2755e12
commit f8e7334
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 10 deletions.
diff --git a/client/app/components/Parameters.jsx b/client/app/components/Parameters.jsx
@@ -16,7 +16,7 @@ function updateUrl(parameters) {
   parameters.forEach(param => {
     extend(params, param.toUrlParams());
   });
-  location.setSearch(params);
+  location.setSearch(params, true);
 }
 
 export default class Parameters extends React.Component {

diff --git a/client/app/components/items-list/classes/StateStorage.js b/client/app/components/items-list/classes/StateStorage.js
@@ -47,11 +47,14 @@ export class UrlStateStorage extends StateStorage {
 
   // eslint-disable-next-line class-methods-use-this
   setState({ page, itemsPerPage, orderByField, orderByReverse, searchTerm }) {
-    location.setSearch({
-      page,
-      page_size: itemsPerPage,
-      order: compileOrderBy(orderByField, orderByReverse),
-      q: searchTerm !== "" ? searchTerm : null,
-    });
+    location.setSearch(
+      {
+        page,
+        page_size: itemsPerPage,
+        order: compileOrderBy(orderByField, orderByReverse),
+        q: searchTerm !== "" ? searchTerm : null,
+      },
+      true
+    );
   }
 }
diff --git a/client/app/pages/dashboards/useDashboard.js b/client/app/pages/dashboards/useDashboard.js
@@ -72,7 +72,7 @@ function useFullscreenHandler() {
   const [fullscreen, setFullscreen] = useState(has(location.search, "fullscreen"));
   useEffect(() => {
     document.body.classList.toggle("headless", fullscreen);
-    location.setSearch({ fullscreen: fullscreen ? true : null });
+    location.setSearch({ fullscreen: fullscreen ? true : null }, true);
   }, [fullscreen]);
 
   const toggleFullscreen = () => setFullscreen(!fullscreen);
@@ -83,7 +83,7 @@ function useRefreshRateHandler(refreshDashboard) {
   const [refreshRate, setRefreshRate] = useState(getRefreshRateFromUrl());
 
   useEffect(() => {
-    location.setSearch({ refresh: refreshRate || null });
+    location.setSearch({ refresh: refreshRate || null }, true);
     if (refreshRate) {
       const refreshTimer = setInterval(refreshDashboard, refreshRate * 1000);
       return () => clearInterval(refreshTimer);
@@ -100,7 +100,7 @@ function useEditModeHandler(canEditDashboard, widgets) {
   const [doneBtnClickedWhileSaving, setDoneBtnClickedWhileSaving] = useState(false);
 
   useEffect(() => {
-    location.setSearch({ edit: editingLayout ? true : null });
+    location.setSearch({ edit: editingLayout ? true : null }, true);
   }, [editingLayout]);
 
   useEffect(() => {