Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More communicative/friendlier UI #1

Closed
4 of 5 tasks
arikfr opened this issue Oct 28, 2013 · 8 comments
Closed
4 of 5 tasks

More communicative/friendlier UI #1

arikfr opened this issue Oct 28, 2013 · 8 comments
Labels
Milestone

Comments

@arikfr
Copy link
Member

arikfr commented Oct 28, 2013

  • Notification when save fails
  • Show notification when the query has changed, but not saved
  • Show confirm box, when trying to leave the page before saving the query
  • Turn back on browser notifications
  • Show error message when execute fails
@arikfr
Copy link
Member Author

arikfr commented Oct 28, 2013

For the notification when leaving the page:

    var leavingPageText = "You'll lose your changes if you leave";
    window.onbeforeunload = function(){
        return leavingPageText;
    }

    $scope.$on('$locationChangeStart', function(event, next, current) {
        if(!confirm(leavingPageText + "\n\nAre you sure you want to leave this page?")) {
            event.preventDefault();
        }
    });

@amirnissim
Copy link
Contributor

TODO: make the navigation alert re-usable on other pages

@arikfr
Copy link
Member Author

arikfr commented Dec 31, 2013

@amirnissim this kind of TODOs I write as comments in the code :-)

@amirnissim
Copy link
Contributor

you merged the PR before I got a chance to amend it :/

@amirnissim
Copy link
Contributor

"Show notification when the query has changed, but not saved" should probably apply also to the query name and description right?

@arikfr
Copy link
Member Author

arikfr commented Jan 6, 2014

Right indeed.

@amirnissim
Copy link
Contributor

what about [5]?

@arikfr
Copy link
Member Author

arikfr commented Jan 23, 2014

Not that important.

arikfr added a commit that referenced this issue May 13, 2014
arikfr added a commit that referenced this issue May 13, 2014
@arikfr arikfr mentioned this issue Jul 29, 2014
arikfr pushed a commit that referenced this issue May 7, 2015
add requirements.txt and migrations to vagrant instructions
arikfr pushed a commit that referenced this issue Oct 8, 2015
Upgrade PivotTable.js and enable TSV export
arikfr pushed a commit that referenced this issue Feb 3, 2016
arikfr pushed a commit that referenced this issue Sep 14, 2016
update master from upstream
arikfr pushed a commit that referenced this issue Jun 28, 2017
arikfr pushed a commit that referenced this issue Oct 1, 2017
* Feature: Query based parameter (drop-down)

* Restrict to string column for query parameter

* Fix lint errors
arikfr pushed a commit that referenced this issue Oct 18, 2017
merge base master with this fork
harmy added a commit to harmy/redash that referenced this issue Jun 27, 2018
added mobifun portal login

Squashed commit of the following:

commit ed1820a
Author: 许凯 <xukai@mobifun365.net>
Date:   Wed Jun 27 15:46:47 2018 +0800

    redash接入mobifun登陆认证

commit 479db73
Author: 许凯 <xukai@mobifun365.net>
Date:   Wed Jun 27 15:41:02 2018 +0800

    redash接入mobifun登陆认证

commit 4994e36
Author: 许凯 <xukai@mobifun365.net>
Date:   Wed Jun 27 09:02:06 2018 +0800

    redash
arikfr pushed a commit that referenced this issue Jul 2, 2018
pull upstream to my fork
haroldduan added a commit to haroldduan/redash that referenced this issue Jan 15, 2019
Update docker config contents. getredash#1
arikfr pushed a commit that referenced this issue May 16, 2019
* Dashboard grid React migration

* Updated tests

* Fixes comments

* One col layout

* Tests unskipped

* Test fixes

* Test fix

* AutoHeight feature

* Kebab-cased

* Get rid of lazyInjector

* Replace react-grid-layout with patched fork to fix performance issues

* Fix issue with initial layout when page has a scrollbar

* Decrease polling interval (500ms is too slow)

* Rename file to match it's contents

* Added some notes and very minor fixes

* Fix Remove widget button (should be visible only in editing mode); fix widget actions menu

* Fixed missing grid markings

* Enhanced resize handle

* Updated placeholder color

* Render DashboardGrid only when dashboard is loaded
ranbena added a commit that referenced this issue Sep 19, 2019
restyled-io bot pushed a commit that referenced this issue Aug 25, 2020
Table visualization sorts by column type and not by display type
restyled-io bot pushed a commit that referenced this issue Sep 11, 2020
Add changes to use inline metadata.
restyled-io bot pushed a commit that referenced this issue Apr 19, 2021
restyled-io bot pushed a commit that referenced this issue Jul 27, 2021
…-components

Snlbattery 13 experiment with table components
susodapop pushed a commit that referenced this issue Jan 19, 2022
* refactoring

* add limit text for oracle

* simplify logic

* add tests for oracle

* move tests to query runner

* remove unused tests
restyled-io bot pushed a commit that referenced this issue Mar 9, 2022
Added unixodbc to dockerfile
guidopetri pushed a commit that referenced this issue Jul 21, 2023
* Restyled by autopep8

* Restyled by black

* Restyled by clang-format

* Restyled by isort

* Restyled by prettier

* Restyled by reorder-python-imports

* Restyled by whitespace

* Restyled by yapf

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants