Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide widget level filters when dashboard filters are active #3074

Open
s1moe2 opened this issue Nov 13, 2018 · 0 comments
Open

Hide widget level filters when dashboard filters are active #3074

s1moe2 opened this issue Nov 13, 2018 · 0 comments

Comments

@s1moe2
Copy link

s1moe2 commented Nov 13, 2018

Issue Summary

When dashboard level filters are enabled, all widgets still keep their individual filters, which produces a lot of visual noise and redundancy (I also found this mentioned on discuss).
There may be use cases when both dashboard and widget level filters are needed but generally I see this as a "switch".

Technical details:

I've tried locally and came up with a simple solution to hide the widget filters according to the flag affected by the setting by basically adding this ng-if in [client/app/visualizations/index.js] (and a couple more lines, ofc):
template: `<filters ng-if="!dashboardFiltersEnabled" filters="filters"></filters>\n${Visualization.renderVisualizationsTemplate}`,
If I get some positive feedback on this and this behaviour makes sense, I'll create the PR.

But... As I mentioned (and I'm looking for feedback here), there may be situations when both dashboard and widget level filters are needed. For this case I suggest adding an extra setting along with "Use Dashboard Level Filters", such as "Show Widget Level Filters", for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant