Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add option to hide widget level filters #3760

Closed

Conversation

yoavbls
Copy link
Contributor

@yoavbls yoavbls commented May 4, 2019

What type of PR is this? (check all applicable)

  • Feature

Description

When dashboard filters are enabled all the widgets still keep their filters and make
a lot of visual noise and redundancy.
In this PR I Added another flag that shows only when dashboard filters are checked
and let you choose to hide the filters in the widget level.

Related Tickets & Documents

#3074

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Before:
image

After:
image

@yoavbls yoavbls changed the title Add option to hide widget level filters Feature: Add option to hide widget level filters May 4, 2019
@rauchy rauchy requested a review from arikfr May 5, 2019 05:45
@rauchy
Copy link
Contributor

rauchy commented May 5, 2019

Thanks @yoavbls, LGTM.

I'm wondering if two checkboxes are even required - maybe selecting dashboard level filters should automatically hide widget filters? WDYT @arikfr?

@arikfr
Copy link
Member

arikfr commented May 13, 2019

I'm wondering if two checkboxes are even required - maybe selecting dashboard level filters should automatically hide widget filters? WDYT @arikfr?

This makes sense. I just wonder if it's worth having both options for the sake of backward compatibility? 🤔

@rauchy
Copy link
Contributor

rauchy commented May 13, 2019

I just wonder if it's worth having both options for the sake of backward compatibility? 🤔

I think we should bite the bullet and allow toggling between dashboard-level and widget-level. Having both displayed feels confusing to me.

@arikfr
Copy link
Member

arikfr commented Jan 21, 2020

Hi,

(This is a template message, but I mean every word of it. Also you're welcome to reply)

Thank you for making this contribution. While we couldn't bring it to completion and merge, it's still very much appreciated. 🙇

In the past year the Redash code base gone under massive updates: on the backend we moved to Python 3 & RQ instead of Celery and on the frontend we replaced Angular with React. It's very likely this makes this PR irrelevant without significant changes. :-(

I'm closing this PR now. But if you're still interested in making it happen, let me know and I will reopen.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants