Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save query only when actually updating the schedule and not on OK #3918

Closed
arikfr opened this issue Jun 19, 2019 · 1 comment · Fixed by #3919
Closed

Save query only when actually updating the schedule and not on OK #3918

arikfr opened this issue Jun 19, 2019 · 1 comment · Fixed by #3919
Assignees
Milestone

Comments

@arikfr
Copy link
Member

arikfr commented Jun 19, 2019

Currently when you open the query schedule dialog and click on OK, it will save the query - even if no changes were made. This updates the query's updated_at timestamp and makes it hard to track when it was really changed.

Expected behavior: if no changes to the schedule were made, don't save the query even if OK was pressed.

@arikfr arikfr added this to the Next milestone Jun 19, 2019
@ranbena ranbena self-assigned this Jun 19, 2019
@ranbena
Copy link
Contributor

ranbena commented Jun 19, 2019

Actually, the schedule dialog is already set to save only if changed:

// save if changed
if (!isEqual(newSchedule, this.props.schedule)) {
if (newSchedule.interval) {
this.props.dialog.close(clone(newSchedule));
} else {
this.props.dialog.close(null);
}
}
this.props.dialog.dismiss();

But I think it wasn't adapted to schedule = null after #3341.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants