Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix schedule dialog needless confirm saves #3919

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Fix schedule dialog needless confirm saves #3919

merged 1 commit into from
Jun 20, 2019

Conversation

ranbena
Copy link
Contributor

@ranbena ranbena commented Jun 19, 2019 •
edited
Loading

  • Bug Fix

Fixes #3918.

Description

"Save on change" is already a feature in the schedule dialog but since backend work allowing schedule to be null the comparison is faulty.

STR:

  1. Create new query.
  2. Open scheduler, change nothing, click ok.

Expected: No save.
Actual: Yes save.

Fixed by comparing after dict compaction.

@ranbena ranbena requested a review from arikfr June 19, 2019 13:38
@ranbena ranbena self-assigned this Jun 19, 2019
@arikfr arikfr merged commit 9ee393e into master Jun 20, 2019
@arikfr arikfr deleted the null branch June 20, 2019 05:54
@weekly-digest weekly-digest bot mentioned this pull request Jun 24, 2019
Closed
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
@ranbena @harveyrendell
Fix schedule dialog needless confirm saves (getredash#3919)
0374ba9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arikfr arikfr Awaiting requested review from arikfr

Assignees

@ranbena ranbena

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save query only when actually updating the schedule and not on OK
2 participants
@ranbena @arikfr