Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for forking the query and retaining the schedule #424

Closed
runa opened this issue May 11, 2015 · 5 comments
Closed

Allow for forking the query and retaining the schedule #424

runa opened this issue May 11, 2015 · 5 comments

Comments

@runa
Copy link
Contributor

runa commented May 11, 2015

  1. Create a new query, set a refresh schedule
  2. Fork it: the new query doesn't has the refresh schedule set.
@arikfr
Copy link
Member

arikfr commented May 11, 2015

Actually this is by design. I wanted to avoid situation that queries get scheduled by mistake, just because the original one was scheduled.

@runa
Copy link
Contributor Author

runa commented May 11, 2015

mrmr. I'm mostly forking queries to make them execute at another
datasource; so I really want to copy the schedule ;)

does the query results cache works by hashing the query text or it does it
by query-id? if it's in the first case, it wouldn't be a problem if you
duplicated the schedule without noticing it because the query won't be run
again (because of the query cache)

On Mon, May 11, 2015 at 2:48 PM, Arik Fraimovich notifications@github.com
wrote:

Actually this is by design. I wanted to avoid situation that queries get
scheduled by mistake, just because the original one was scheduled.


Reply to this email directly or view it on GitHub
#424 (comment)
.

@arikfr
Copy link
Member

arikfr commented May 12, 2015

Well, the use case around fork is usually different: you want to fork it to play around with the query or change something. In such cases, caching won't help as the user will end up running a different query (but you're correct that it's done using query text).

I won't change the default behavior of fork, but it's possible to add another fork button that retains the scheduling...

@arikfr arikfr changed the title forked queries do not copy the schedule Allow for forking the query and retaining the schedule May 12, 2015
@runa
Copy link
Contributor Author

runa commented May 12, 2015

Super Fork?
Maybe "Clone" ?

On Tue, May 12, 2015 at 2:56 AM, Arik Fraimovich notifications@github.com
wrote:

Well, the use case around fork is usually different: you want to fork it
to play around with the query or change something. In such cases, caching
won't help as the user will end up running a different query (but you're
correct that it's done using query text).

I won't change the default behavior of fork, but it's possible to add
another fork button that retains the scheduling...


Reply to this email directly or view it on GitHub
#424 (comment)
.

@arikfr
Copy link
Member

arikfr commented Jun 14, 2016

It's not a common enough use case to make the UI more complex than it is now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants