Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to clear reference to last query result after changing query #46

Closed
arikfr opened this issue Dec 17, 2013 · 2 comments
Closed

Make sure to clear reference to last query result after changing query #46

arikfr opened this issue Dec 17, 2013 · 2 comments
Labels
Bug Frontend

Comments

@arikfr
Copy link
Member

arikfr commented Dec 17, 2013

STR:

  1. Write a query and execute.
  2. Change the query while it's executing and save.
  3. When the query returns, it will update the query object, although it's not the same query.
@arikfr arikfr added this to the v0.3 milestone Mar 24, 2014
@amirnissim
Copy link
Contributor

hmm... you can't edit a query while it is executing:
https://github.com/EverythingMe/redash/blob/master/rd_ui/app/scripts/directives/query_directives.js#L61-L63

still relevant? @arikfr

@amirnissim amirnissim self-assigned this Apr 3, 2014
@arikfr
Copy link
Member Author

arikfr commented Apr 8, 2014

  1. This is a new behavior :-)
  2. There are still cases when the query is not locked (for example when you click on "+ New" in a unsaved query).

@arikfr arikfr modified the milestones: Next, v0.4 Jul 20, 2014
@arikfr arikfr removed this from the Next milestone Dec 10, 2015
@arikfr arikfr closed this as completed May 1, 2016
robotblake pushed a commit to robotblake/redash that referenced this issue Apr 19, 2017
show data source type when no doc link present (re getredash#46)
76b39a1
washort pushed a commit to washort/redash that referenced this issue Jul 25, 2017
@alison985
Show sql dialect if no doc_url
b062398 
getredash#46
washort pushed a commit to washort/redash that referenced this issue Dec 8, 2017
Documentation links for data sources
372851d 
(incorporates: show data source type when no doc link present (re getredash#46))
washort pushed a commit to washort/redash that referenced this issue Dec 13, 2017
Documentation links for data sources (re getredash#6)
2e141f5 
(incorporates: show data source type when no doc link present (re getredash#46))
washort pushed a commit to washort/redash that referenced this issue Jan 8, 2018
Documentation links for data sources (re getredash#6)
9773a0c 
(incorporates: show data source type when no doc link present (re getredash#46))
washort pushed a commit to washort/redash that referenced this issue Jan 9, 2018
Documentation links for data sources (re getredash#6)
ffc6f0f 
(incorporates: show data source type when no doc link present (re getredash#46))
washort pushed a commit to washort/redash that referenced this issue Apr 30, 2018
@jezdez
Documentation links for data sources (re getredash#6)
75228b2 
(incorporates: show data source type when no doc link present (re getredash#46))
washort pushed a commit to washort/redash that referenced this issue May 31, 2018
Documentation links for data sources (re getredash#6)
7b85d06 
(incorporates: show data source type when no doc link present (re getredash#46))
@snyk-bot snyk-bot mentioned this issue May 16, 2022
Merged
justinclift pushed a commit to junnplus/redash that referenced this issue Jun 24, 2023
@Avey777
Merge pull request getredash#46 from Avey777/master
02cbe11 
Hide filter components when sharing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arikfr @amirnissim