Visualizations refactor

[arikfr]

I've separated each visualization declaration into its own module, so each visualization defines how to render it and what options it needs. The base visualization render/edit directives are not aware of the visualization types that are available.

Adding a new visualization requires:

1. Write the module.
2. Add the module to the redash.app module dependencies.
3. Include the file in the JS files list in index.html.

I would love if it could be a single step, but not sure how to make #2 and #3 automatic (specially #3).

Would love to get comments and ideas.

[joeysim]

Re 2 and 3, I'd think of it from a convention over configuration angle, where we have a folder with visualization packages, each in its own folder and exposes enough meta data to be properly integrated. When re:dash loads, it will enumerate this folder and allow access to the different visualizations.

In such a model, you would init and render visualizations lazily and on-demand rather than include all when re:dash web page loads.

wdyt?

[arikfr]

It will require some effort in "orchestrating" this, but it's possible:

1. While developing we can use some Jinja template helper that will load all files in /visualizations folder.
2. Configure grunt to "build" (uglify, minify, ...) all files in /visualizations as part of the build process.

This doesn't solve #2 though, but I will RTFM to see if there is some easy solution around it.

Also there is the question of how to handle external dependencies visualizations might have, but for now I would "skip" this and address when needed.

[arikfr]

Ok, #2 is practically solved (see: 1a896e9).

[amirnissim]

@arikfr when would we like to skip types?

[arikfr]

In the case of table.

[amirnissim]

why? isn't that a valid vis. type?

[arikfr]

It's created by default, so we don't need it in the menu.

[amirnissim]

@arikfr how about using a config object here?

this.registerVisualization = function(config) {
  var visualization = {
   rendererTemplate: config.rendererTemplate,
   editorTemplate: config.editorTemplate,
   type: config.type,
   name: config.name,
   defaultOptions: config.defaultOptions || {}
  };
}

[arikfr]

👍

[arikfr]

3320de0

[amirnissim]

Good to merge 👍