Change: add support for Standard SQL in BigQuery query runner #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -132,6 +136,7 @@ def _get_total_bytes_processed(self, jobs, query): | |||
| job_data = { | |||
| "query": query, | |||
| "dryRun": True, | |||
| "useLegacySql": self.configuration.get('useLegacySql', False), | |||
There was a problem hiding this comment.
Unless I misunderstand this, the default should be True because otherwise it will break all existing queries...
There was a problem hiding this comment.
And because it goes unchecked by default, let's change the configuration name to "Use Standard SQL (Beta)".
There was a problem hiding this comment.
Thanks you for your comment!
I'll try to fix that.
|
Thanks! See my comment. |
| @@ -103,6 +103,10 @@ def configuration_schema(cls): | |||
| 'userDefinedFunctionResourceUri': { | |||
| "type": "string", | |||
| 'title': 'UDF Source URIs (i.e. gs://bucket/date_utils.js, gs://bucket/string_utils.js )' | |||
| }, | |||
| 'useStandardSql(Beta)': { | |||
There was a problem hiding this comment.
Why have the (Beta) part in the key name?
There was a problem hiding this comment.
Sorry, I misunderstand your comment. I'll remove (Beta) from key name.
arikfr
changed the title
arikfr
changed the title
simo7
pushed a commit
to pubnative/redash
that referenced
this pull request
Sep 22, 2016
…sql-type Change: add support for Standard SQL in BigQuery query runner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add checkbox to specify whether to use legacy or standard sql.
legacy: https://cloud.google.com/bigquery/query-reference
standard: https://cloud.google.com/bigquery/sql-reference/
updated:
