Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: improvements to map visualization #1292

Merged
merged 5 commits into from
Oct 8, 2016
Merged

Conversation

arikfr
Copy link
Member

@arikfr arikfr commented Sep 22, 2016

image

image

@arikfr arikfr added this to the v0.12.0 milestone Sep 22, 2016
@arikfr
Copy link
Member Author

arikfr commented Sep 22, 2016

@WesleyBatista I didn't implement any special settings. If there are any settings you want me to port from your code, let me know and I will add it. Thanks!

@WesleyBatista
Copy link
Contributor

Really thanks for implementing it!

I just had time to test it today. Here are my thoughts:

1. I really like that now we can use group by in the visualization settings, and now we are able to select the groups that we want to see in the visualization. 👏 👏 👏
captura de tela 2016-09-26 as 17 58 20

2. The colors used by the marker cluster library and ours is not managed very well. for example, take a look at this 5 blue points:
captura de tela 2016-09-26 as 17 46 59
captura de tela 2016-09-26 as 17 46 39
When zooming out, the 4 closer to each other are clustered and the color is set to green.

The same issue within another use case: looking at the yellow clusters in the next image, I find clusters with the same colors closer to each other, and start to wondering "why they were not grouped?", but I know that we have 5 different groups because I used the group by.
captura de tela 2016-09-26 as 18 02 06
It would be more meaningful if the colors used was the group's color, so I would also know which groups they belongs.

3. the custom layers is something that I miss. The OpenStreet Map default tiles is messy by showing a lot of information in the map, and the colors it uses mixes with the ones used by the clusters/groups. For example, look at this two images:
captura de tela 2016-09-26 as 18 29 29

captura de tela 2016-09-26 as 17 55 40
The Stamen Toner layers are more clear by showing only the necessary. That way the user which is taking care of a dashboard, for example, can focus on the main information which is the clusters.

For now that is what I found 😄

@arikfr
Copy link
Member Author

arikfr commented Sep 27, 2016

@WesleyBatista thanks! I'll implement both.

@arikfr
Copy link
Member Author

arikfr commented Oct 8, 2016

@WesleyBatista added both things.

@arikfr arikfr merged commit 39aaa2f into master Oct 8, 2016
@arikfr arikfr deleted the add-cluster-marker branch October 8, 2016 12:37
@shyamgopal
Copy link
Contributor

Thank you so much @arikfr and @WesleyBatista !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants