Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout button #136

Merged
merged 1 commit into from
Mar 13, 2014
Merged

Logout button #136

merged 1 commit into from
Mar 13, 2014

Conversation

amirnissim
Copy link
Contributor

No description provided.

@amirnissim
Copy link
Contributor Author

@arikfr looks like /logout doesn't work?

@arikfr
Copy link
Member

arikfr commented Mar 12, 2014

@amirnissim why not? it works for me. it might have some issue with the URL it redirects you to.

@arikfr
Copy link
Member

arikfr commented Mar 12, 2014

About the button, are you sure it's clear it's there and what it does?

@amirnissim
Copy link
Contributor Author

The icon is pretty clear IMO, and it says 'Logout' on hover.
Still doesn't work for me though (even when typing /logout in the address
bar)

@arikfr
Copy link
Member

arikfr commented Mar 12, 2014

I see that it doesn't work for me either when I click on it, but works when I type in the address bar.
I think Angular catches it and redirects you to '/' (the default route).

@amirnissim
Copy link
Contributor Author

@arikfr already tried it 7956567120f3615c41163e99e74b3f745c5fddf5. doesn't work :/

@arikfr
Copy link
Member

arikfr commented Mar 12, 2014

@amirnissim use window.location.replace('/logout'); to avoid Angular catching the url change.

@amirnissim
Copy link
Contributor Author

what happens is that /logout redirects to /login (that's ok) but then the user is automatically logged in again if the password is saved by the browser.

IMO this is a bug since it makes it impossible to sign out without clearing the password saved in the browser and it is not clear what's going on.

@amirnissim
Copy link
Contributor Author

97d6146 implements the UI but user is unable to effectively logout because of previous comment

@arikfr
Copy link
Member

arikfr commented Mar 13, 2014

@amirnissim I don't think it auto signs in when using password authentication. It happens only with Google Apps authentication.

arikfr added a commit that referenced this pull request Mar 13, 2014
@arikfr arikfr merged commit dd8478f into master Mar 13, 2014
@amirnissim
Copy link
Contributor Author

@arikfr either way - bottom line is it is impossible to logout.

@amirnissim amirnissim deleted the logout branch March 13, 2014 11:18
christophervalles pushed a commit to hailocab/redash that referenced this pull request May 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants