-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logout button #136
Logout button #136
Conversation
@arikfr looks like /logout doesn't work? |
@amirnissim why not? it works for me. it might have some issue with the URL it redirects you to. |
About the button, are you sure it's clear it's there and what it does? |
The icon is pretty clear IMO, and it says 'Logout' on hover. |
I see that it doesn't work for me either when I click on it, but works when I type in the address bar. |
@arikfr already tried it 7956567120f3615c41163e99e74b3f745c5fddf5. doesn't work :/ |
@amirnissim use |
what happens is that /logout redirects to /login (that's ok) but then the user is automatically logged in again if the password is saved by the browser. IMO this is a bug since it makes it impossible to sign out without clearing the password saved in the browser and it is not clear what's going on. |
97d6146 implements the UI but user is unable to effectively logout because of previous comment |
@amirnissim I don't think it auto signs in when using password authentication. It happens only with Google Apps authentication. |
@arikfr either way - bottom line is it is impossible to logout. |
Logout button
No description provided.