Add: rate limit the login page #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoineAugusti
force-pushed
the
rate-limit-login
branch
from
b454fa8
to
7b68953
Compare
|
Added a test + squashed |
arikfr
reviewed
Nov 2, 2016
| @@ -81,6 +81,7 @@ def forgot_password(org_slug=None): | |||
|
|
|||
|
|
|||
| @routes.route(org_scoped_rule('/login'), methods=['GET', 'POST']) | |||
| @limiter.limit("50/hour") | |||
|
Added a conf variable |
|
@arikfr Anything blocking this PR for being merged? |
|
Sorry for not mentioning earlier -- I'm no longer merging stuff until I finish with the 0.12 release (#1378). Once it's out, I will merge it. |
|
Hi, @AntoineAugusti - because I removed the |
AntoineAugusti
force-pushed
the
rate-limit-login
branch
from
4863746
to
c440df9
Compare
AntoineAugusti
force-pushed
the
rate-limit-login
branch
from
c440df9
to
9118464
Compare
|
@arikfr Rebased and squashed 👍 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #115
Straightforward use of Flask limiter https://flask-limiter.readthedocs.io