Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vertica] Change: set longer read_timeout #1528

Merged
merged 3 commits into from
Jan 17, 2017
Merged

[Vertica] Change: set longer read_timeout #1528

merged 3 commits into from
Jan 17, 2017

Conversation

lab79
Copy link
Contributor

@lab79 lab79 commented Jan 16, 2017

@arikfr arikfr changed the title add read_timeout [Vertica] Change: set longer read_timeout Jan 16, 2017
arikfr
arikfr reviewed Jan 16, 2017
View reviewed changes
redash/query_runner/vertica.py
@@ -109,7 +109,8 @@ def run_query(self, query, user):
'port': self.configuration.get('port', 5433),
'user': self.configuration.get('user', ''),
'password': self.configuration.get('password', ''),
'database': self.configuration.get('database', '')
'database': self.configuration.get('database', ''),
'read_timeout': self.configuration.get('read_timeout', 60000)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in seconds? Maybe let's have a lower default - 4 hours (14400)?

@lab79
Copy link
Contributor Author

lab79 commented Jan 16, 2017

Yes, seconds https://pypi.python.org/pypi/vertica-python/ (mistakenly thought that millisecond)
Propose leave the default - 10 minutes (600)

@arikfr
Copy link
Member

arikfr commented Jan 16, 2017

Just noticed you added this to configuration, then yes - let's keep the default value same as the default. Also you need to add this to the configuration_schema so it will show up in the UI.

@arikfr arikfr merged commit 8b74de7 into getredash:master Jan 17, 2017
@arikfr
Copy link
Member

arikfr commented Jan 17, 2017

Thanks!

dairyo pushed a commit to KiiCorp/redash that referenced this pull request Mar 1, 2019
@arikfr
Merge pull request getredash#1528 from lab79/patch-1
1e61ab0 
[Vertica] Change: set longer read_timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arikfr arikfr arikfr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lab79 @arikfr