[#90] UI issues

[amirnissim]

No description provided.

[arikfr]

Better use ng-href, no?

[amirnissim]

that's what I did initially, but:
<a ng-href="/queries/{{query.id}}#{{visualization.id}}"></a>
will render with a trailing # when no visualization: /queries/123# and I don't like it 👎

[arikfr]

No, bind ng-href with some scope property which will contain the final URL that the directive generates.

[amirnissim]

but that would beat the purpose of using a directive. I want to have /queries/ written in one place.

[arikfr]

Why will it be written in more than one place this way?

[amirnissim]

<query-link hrefValue="/queries/{{query1.id}}#{{visualization1.id}}"></query-link>
<query-link hrefValue="/queries/{{query2.id}}#{{visualization2.id}}"></query-link>

is that what you mean?

On Wed, Mar 26, 2014 at 1:32 PM, Arik Fraimovich
notifications@github.comwrote:

In rd_ui/app/scripts/directives/query_directives.js:

• function queryLink() {
• return {

•  restrict: 'E',
  

•  scope: {
  

•    'query': '=?',
  

•    'visualization': '=?'
  

•  },
  

•  template: '<a>{{query.name
  

  }}',

•  link: function(scope, element) {
  

•    scope.query = scope.query || scope.$parent.query;
  

•    var link = '/queries/' + scope.query.id;
  

•    if (scope.visualization) {
  

•      link += '#' + scope.visualization.id;
  

•    }
  

•    element.find('a').attr('href', link);
  

Why will it be written in more than one place this way?

Reply to this email directly or view it on GitHubhttps://github.com//pull/154/files#r10972230
.

http://everything.me/
Amir Nissim
Front End Developer, EverythingMe http://everything.me/
amirn@everything.me amirn@everything.me +972 52 6342974

[arikfr]

No. I meant that in queryLink's template you will use ng-href.

[amirnissim]

that's what I did initially, but:
<a ng-href="/queries/{{query.id}}#{{visualization.id}}"></a>
will render with a trailing # when no visualization: /queries/123# and I don't like it 👎

[amirnissim]

done 40adba4