Make sure qr serialization will always be in JSON #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… end up serializing big objects - so that other parts of the system can be written in languages other than Python
arikfr
added a commit
that referenced
this pull request
Apr 7, 2014
Make sure qr serialization will always be in JSON
christophervalles
pushed a commit
to hailocab/redash
that referenced
this pull request
May 8, 2014
Make sure qr serialization will always be in JSON
washort
pushed a commit
to washort/redash
that referenced
this pull request
Sep 6, 2017
add catching key error & removing data_scanned from url query_runner
dairyo
pushed a commit
to KiiCorp/redash
that referenced
this pull request
Mar 1, 2019
Make sure qr serialization will always be in JSON
dairyo
pushed a commit
to KiiCorp/redash
that referenced
this pull request
Mar 1, 2019
Make sure qr serialization will always be in JSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the sake of future proofing parts of that systems that can be implemented in other languages (like the query runner), make sure that qr will only serialize complex structures using JSON instead of Pickle.