Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when exporting list data as Excel file #2060

Merged
merged 1 commit into from
Oct 29, 2017

Conversation

kyoshidajp
Copy link
Member

@kyoshidajp kyoshidajp commented Oct 28, 2017

About #2051.

XlsxWriter's .write() is not support list data. My solution is convert to string.

And, I have already checked the following BSON Types in MongoDB is OK.

  • Array
  • String
  • Integer
  • Boolean
  • Object
  • Date
  • Timestamp
  • Symbol

@arikfr arikfr merged commit 9874361 into getredash:master Oct 29, 2017
@arikfr
Copy link
Member

arikfr commented Oct 29, 2017

Thanks!

@thijsc
Copy link

thijsc commented Oct 29, 2017

Awesome, thanks!

@kyoshidajp kyoshidajp deleted the fix_export_excel branch October 29, 2017 18:58
dairyo pushed a commit to KiiCorp/redash that referenced this pull request Mar 1, 2019
Fix error when exporting list data as Excel file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants