Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade psycopg2 for support PostgreSQL 10.0 #2111

Merged
merged 2 commits into from
Dec 2, 2017

Conversation

kyoshidajp
Copy link
Member

Run pip install after install PostgreSQL 10.0, the following error has occurred.

% pip install -r requirements.txt -r requirements_dev.txt
Collecting psycopg2==2.5.2 (from -r requirements.txt (line 21))
  Using cached psycopg2-2.5.2.tar.gz
    Complete output from command python setup.py egg_info:
    running egg_info
    creating pip-egg-info/psycopg2.egg-info
    writing pip-egg-info/psycopg2.egg-info/PKG-INFO
    writing top-level names to pip-egg-info/psycopg2.egg-info/top_level.txt
    writing dependency_links to pip-egg-info/psycopg2.egg-info/dependency_links.txt
    writing manifest file 'pip-egg-info/psycopg2.egg-info/SOURCES.txt'
    warning: manifest_maker: standard file '-c' not found

    Error: could not determine PostgreSQL version from '10.1'

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /private/var/folders/_4/_g1sfpnx2tzf_nck0dqzc7xh0000gp/T/pip-build-wEEbyQ/psycopg2/

According to psycopg/psycopg2#489, psycopg2 already fixed this issue.

How about upgrading psycopg2 version. Or with Docker image.

requirements.txt Outdated
@@ -18,7 +18,7 @@ Flask-Limiter==0.9.3
passlib==1.6.2
aniso8601==1.1.0
blinker==1.3
psycopg2==2.5.2
psycopg2==2.7.3.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any special reason to use 2.7.3.1 instead of 2.7.3.2?

@kyoshidajp
Copy link
Member Author

@arikfr I was wrong. Already fixed the version.

@arikfr arikfr merged commit 7974c90 into getredash:master Dec 2, 2017
@arikfr
Copy link
Member

arikfr commented Dec 2, 2017

Thanks.

@kyoshidajp kyoshidajp deleted the upgrade_psycopg2 branch December 3, 2017 06:20
@kyoshidajp kyoshidajp mentioned this pull request Dec 3, 2017
@gabrielkoerich
Copy link

@arikfr Isn't this updated in 3.0? I'm trying to install in ubuntu 16.04 using the sh file and still get this error.

@RichardLitt
Copy link

@gabrielkoerich It should be. Could you open a support issue in the forum, for now, and we'll see if we can replicate this?

openstack-gerrit pushed a commit to openstack/ironic that referenced this pull request Mar 14, 2019
lower-constraints job is broken due to fail to install psycopg.

Spotted log:

http://logs.openstack.org/02/642402/6/check/openstack-tox-lower-constraints/ca317fe/job-output.txt.gz#_2019-03-14_01_51_01_006156

Add libpq-dev to the bindep and bump psycopg version to >= 2.7 as evidence
shows it has a bug to support PostgreSQL >= 10.0 [1]

[1] getredash/redash#2111

Change-Id: I1d5f0dab41638be1df9d63ede267f5a6d9f8c566
openstack-gerrit pushed a commit to openstack/openstack that referenced this pull request Mar 14, 2019
* Update ironic from branch 'master'
  - Fix lower-constraints job
    
    lower-constraints job is broken due to fail to install psycopg.
    
    Spotted log:
    
    http://logs.openstack.org/02/642402/6/check/openstack-tox-lower-constraints/ca317fe/job-output.txt.gz#_2019-03-14_01_51_01_006156
    
    Add libpq-dev to the bindep and bump psycopg version to >= 2.7 as evidence
    shows it has a bug to support PostgreSQL >= 10.0 [1]
    
    [1] getredash/redash#2111
    
    Change-Id: I1d5f0dab41638be1df9d63ede267f5a6d9f8c566
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants