Add support for types in BigQuery #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| elif field['type'] == 'BOOLEAN': | ||
| cell_value = cell_value in ('True', 'true', 'TRUE') | ||
|
|
There was a problem hiding this comment.
You might want to add support for date/time fields too, otherwise you will have issues with charts.
|
Thanks for this, @jeremi! See my other 2 comments, and let me know if you plan to implement the extra changes or you prefer me to merge this already. |
|
Yes, I will. Jeremi |
|
I think for now the easiest thing to do will be to conver the TIMESTAMP to datetime object ( |
Fix the type field
|
That should fix the 2 issues mentioned earlier. |
arikfr
added a commit
that referenced
this pull request
Jun 27, 2014
Add support for types in BigQuery
|
+1 |
washort
pushed a commit
to washort/redash
that referenced
this pull request
Dec 13, 2017
washort
pushed a commit
to washort/redash
that referenced
this pull request
Jan 8, 2018
washort
pushed a commit
to washort/redash
that referenced
this pull request
Jan 9, 2018
washort
pushed a commit
to washort/redash
that referenced
this pull request
Apr 30, 2018
washort
pushed a commit
to washort/redash
that referenced
this pull request
May 31, 2018
washort
pushed a commit
to washort/redash
that referenced
this pull request
Aug 11, 2018
alison985
pushed a commit
to StantonVentures/redash
that referenced
this pull request
Aug 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.