Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#245] Add refresh button to query view page #247

Merged
merged 1 commit into from
Aug 3, 2014
Merged

[#245] Add refresh button to query view page #247

merged 1 commit into from
Aug 3, 2014

Conversation

amirnissim
Copy link
Contributor

fixes #245

@arikfr
Copy link
Member

arikfr commented Aug 3, 2014

  1. The button should become disabled when query executing.
  2. Button color - should either be white (default) or primary (blue).

@amirnissim
Copy link
Contributor Author

The button should become disabled when query executing.

it is
screen shot 2014-08-03 at 11 46 04 am

Button color - should either be white (default) or primary (blue).

updated PR.

@arikfr
Copy link
Member

arikfr commented Aug 3, 2014

@amirnissim I tried running it locally and it wasn't getting disabled. Can you make sure?

@amirnissim
Copy link
Contributor Author

@arikfr
removed the getError watch, it works now

arikfr added a commit that referenced this pull request Aug 3, 2014
@arikfr
Merge pull request #247 from EverythingMe/245-refresh-btn
c2d621a 
[#245] Add refresh button to query view page
@arikfr arikfr merged commit c2d621a into master Aug 3, 2014
@arikfr arikfr deleted the 245-refresh-btn branch April 1, 2015 14:25
jezdez pushed a commit to jezdez/redash that referenced this pull request Nov 1, 2017
@alison985
adds redash db size metrics to status page
e79e0c8 
getredash#247
jezdez pushed a commit to jezdez/redash that referenced this pull request Nov 1, 2017
@alison985
updates on PR comments re: getredash#247
66d4f49
washort pushed a commit to washort/redash that referenced this pull request Dec 8, 2017
@alison985
updates on PR comments re: getredash#247
fe538a6
washort pushed a commit to washort/redash that referenced this pull request Dec 13, 2017
@alison985
adds redash db size metrics to status page (re getredash#247)
716991e
washort pushed a commit to washort/redash that referenced this pull request Jan 8, 2018
@alison985
adds redash db size metrics to status page (re getredash#247)
c0fa140
washort pushed a commit to washort/redash that referenced this pull request Jan 9, 2018
@alison985
adds redash db size metrics to status page (re getredash#247)
9b1b27b
washort pushed a commit to washort/redash that referenced this pull request Apr 30, 2018
@alison985 @jezdez
adds redash db size metrics to status page (re getredash#247)
df97310
washort pushed a commit to washort/redash that referenced this pull request May 31, 2018
@alison985
adds redash db size metrics to status page (re getredash#247)
a33dbf9
@chr0m1ng chr0m1ng mentioned this pull request Feb 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refresh button in query view
2 participants
@amirnissim @arikfr