perf: HTTP caching headers for /api/query_results [fixes #228] #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -417,7 +418,8 @@ class QueryResultAPI(BaseResource): | |||
| def get(self, query_result_id): | |||
| query_result = models.QueryResult.get_by_id(query_result_id) | |||
| if query_result: | |||
| return {'query_result': query_result.to_dict()} | |||
| data = json.dumps({'query_result': query_result.to_dict()}) | |||
There was a problem hiding this comment.
this is not how we encode JSON data, see https://github.com/EverythingMe/redash/blob/master/redash/wsgi.py#L28
It will be best, if we can reuse the existing code (json_representation). I see that it takes headers as one param, can you check what the get method needs to return for it to use them?
|
addressed comments. updated PR. 10x |
arikfr
added a commit
that referenced
this pull request
Aug 4, 2014
perf: HTTP caching headers for /api/query_results [fixes #228]
arikfr
added a commit
that referenced
this pull request
Aug 7, 2014
Fix: dashboard filters broken after #252
jezdez
pushed a commit
to jezdez/redash
that referenced
this pull request
Nov 1, 2017
…atus_page 247 add db size to status page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.