Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows using unpublished queries in alerts #2660

Closed
wants to merge 3 commits into from

Conversation

alison985
Copy link
Contributor

fixes #2659

This is a port of Mozilla fork functionality upstream.

Original PR commentary is here: mozilla#97 where Arik specifically said that unpublished queries are excluded from the Dashboard Add Widget dialog on purpose. Therefore, we only added unpublished queries to the alert search.

@arikfr
Copy link
Member

arikfr commented Jul 2, 2018

Actually, the same reasoning I mentioned for Add Widget applies here as well. Basically draft queries are not supposed to be used anywhere, to make sure people publish them and not keep them in this state forever.

Unless there is a very good reason for allowing draft queries in alerts, I don't think we will merge this in...

@arikfr
Copy link
Member

arikfr commented Jul 16, 2018

Closing this for now. Let's re open if there is a reason to change this behavior.

@emtwo
Copy link

emtwo commented Jul 31, 2018

@arikfr, suppose we wanted to make this into an extension for the Mozilla fork. I imagine we could use the Policy object from here #2560 to check if the object passed into Query.search() should have the include_drafts attribute.

This would be a small change in this codebase here to allow the attribute to be added if the policy (only turned on in the Mozilla fork) allows it. In other words, we would only be adding the "extension point" here.

What do you think of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow using unpublished queries in alerts
3 participants