Implement server side pagination and sorting for queries lists #2686
Conversation
|
Since this Pull Request originated from a forked repository, Now cannot deploy it as there are potential security risks. If you are a collaborator on this repository, consider making this Pull Request from a branch on the same repository instead of a fork. |
- Redirect the old search API handler. - Sort by specific database columns or relationships. - Allow showing “my” queries per tag as well.
Also: - Adds page size select tag list. - Adds clear button to search input. - Shows search also on “my” page.
|
Thanks for the PR @jezdez Can we:
And is there any way to make the dropdown look better in Firefox? |
arikfr
changed the title
|
Btw, issue #78 is about when a single query's result is very large and needs pagination. |
There was a problem hiding this comment.
While reviewing I noticed two small issues that I fixed in place:
- Null durations were shown as "0 seconds", which was confusing when trying to sort. Showing as '-' now. (494f43b)
scheduleandcreated_atwere not in the whitelisted order by list. (ccaf849)
Firefox dropdown & moving the page size selector: I'm thinking of switching to Ant's pagination control, which will address these issues. @kocsmy WDYT about this? Do you think it will fit in our design? (once you update the font)
|
@arikfr yes, this is a really nice component. I'll make sure it fits to our current design. |
|
🍾 |
This was initially reported in #78 but also applies to the queries search where the list of results can become quite large depending on the number of queries and search term used.
This was originally reported in mozilla#384 and mozilla#385.
Notes:
The sorting criteria are hardcoded and only allow specified columns (and related columns) to be used.
It adds a page size dropdown to the query-list page (and the appropriate backend handling) and allows clearing the search input to reset the query list to the non search result status.
It deprecates the standalone backend query search handler and redirects requests for it.
I believe the live paginator should also be used in more list views and the non-live paginator deprecated or outright removed.
I'm not sure how Redash is handling API backward compatibility, so I erred on the side of caution and followed a deprecation policy (that could mean removing old APIs after the next version for example).
Screenshot:
TODOs: