-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dot behavior to autocomplete #3092
Conversation
|
||
this.onLoad = (editor) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a reason for those methods to be inside QueryEditor's constructor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷♂️
@washort ?
Well, I tested with a db schema with 10k LMK what you think 😁 |
👍 |
Description
A start on #3067 - Issues 1 and 2.
This changes the dot behavior when writing a query and start separating keyword types as Table Keyword, Column Keyword or Table-column Keyword
With that we separate 2 situations of autocomplete, instead of rendering the entire schema:
This will probably improve the performance and be useful when we introduce aliases or query context.
Notes
Autocomplete not aware of the context (#3067 and #2329)
The dot by default breaks autocomplete words, so I changed its Regexp to include it.
Repeated suggestions when navigating through query pages
This seems to be something that could be affecting the performance.
Whenever would one navigate to a new query page, another completer would be added to langTools. I've changed
addCompleter
tosetCompleters
to fix this.Preview
Before
After
To do
QueryEditor
constructorQueryEditor
methods? 🤔We'll probably have some conflicts with #3091, but nothing huge.
Let me know your thoughts 😁