Feature: Refresh schedule - save/cancel actions #3246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
arikfr
approved these changes
Jan 3, 2019
ranbena
force-pushed
the
feature/refresh-schedule/code-opt
branch
from
da6a596 to
ff00b0a
Compare
ranbena
changed the base branch from
feature/refresh-schedule/code-opt
to
master
ranbena
force-pushed
the
feature/refresh-schedule/save-cancel
branch
from
8d83459 to
5971b87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a PR batch to finalize the refresh-schedule feature.
After merging all changes in to
feature/refresh-schedule/emtwoit should be merged into master.What changed
Currently any change to schedule params saves it.
Was requested to add footer buttons instead - save on "OK", cancel on "X"/"Cancel".
Test it out
In query page, click the refresh scheduler (usually "Never")
Make some changes, click cancel, make sure scheduler remains unchanged.
Make some changes, click ok, make sure scheduler changed accordingly.
Implementation notes
Instead of updating
props.queryon every form input change, I let it update a clone ofprops.query.schedulewhich upon ok triggers update and upon cancel resets the state to the original schedule stored inprops.query.Extra feature - clicking on ok without any change will not trigger a save. For UX reasons.