Added SSL settings for PostgreSQL #3259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Closed
arikfr
requested changes
Jan 8, 2019
There was a problem hiding this comment.
Thanks, @rasmi! But as mentioned on the original issue, we do not use file paths in data source configuration[1]. Instead we should store the certificate itself (like we do for BigQuery service account JSON file for example). This ensures that the Redash server is stateless and can be scaled, if needed.
If psycopg2/libpq doesn't support accepting a certificate instead of a path, we can store it to a temporary location before usage.
[1] MySQL is currently using file paths for the same purpose, but that's legacy we need to redo.
|
Understood, thanks @arikfr. I'm going to close this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit fixes various spacing styles. Second commit adds
sslrootcert,sslcert, andsslkeyparameters to support various PostgreSQL SSL settings: https://www.postgresql.org/docs/current/libpq-ssl.htmlSee #2000.