-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data Sources] Implement Mixpanel #3275
[Data Sources] Implement Mixpanel #3275
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Supporting Mixpanel will be a great addition.
Please see my comments.
this integration is important. |
Co-Authored-By: Arik Fraimovich <arik@arikfr.com>
Co-Authored-By: Arik Fraimovich <arik@arikfr.com>
@kravets-levko @arikfr I just committed my changes regarding your comments. I'm still waiting docker to build containers locally in order to test. |
I can't build with docker. I got the following error message: But, even without testing, I think it'll be working anyway. |
@gabrielsebag IIRC exit code 137 means "no enough memory". I don't know anything about your environment, just check that docker has at least 4Gb free memory at build stage (e.g. if you're using MacOS there are some limits for docker VM). |
Thanks, you were right! I just tested and everything works as expected. |
Any plans on merging this PR on Redash SaaS? |
Hey, there is any news about this integration? |
Hey @shahafc thanks for pinging this. I'd like to get this merged ASAP, but it needs some work. In the time since this PR was first opened, we've released a new guide for writing query runners. There are also a lot of merge conflicts to resolve. @gabrielsebag are you still interested in getting this across the line? Or should we close this PR and open a new PR for others to collaborate? |
Just to let you know a good workaround is using the "JSON" data source and it works fine :) |
Hey @susodapop unfortunately I can't work on it anymore. I suggest that you open a new PR if you think that's necessary. As @shahafc mentioned, it seems that the JSON data source works well :) |
I understand. Thanks anyway for putting in this effort. |
Referring Topic: https://discuss.redash.io/t/mixpanel-integration/2925/4