Closes #3192: Add data source config options. #3292
Conversation
ghost
assigned 
emtwo
force-pushed
the
emtwo/schema2_admin_controls
branch
from
281861d to
3ca1370
Compare
emtwo
force-pushed
the
emtwo/schema2_admin_controls
branch
from
3ca1370 to
8c94c5a
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| for row in results['rows']: | ||
| table_samples = {} | ||
|
|
||
| for i, row in enumerate(results['rows']): |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
|
||
| for row in results['rows']: | ||
| for i, row in enumerate(results['rows']): |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| 'hasColumnMetadata': table.column_metadata, | ||
| 'table_description': table.table_description, | ||
| 'columns': []} | ||
| columns = db.session.query(ColumnMetadata).filter(ColumnMetadata.table_id==table.id) |
There was a problem hiding this comment.
Missing whitespace around operator
| return record.key === this.state.editingKey; | ||
| } | ||
|
|
||
| save(form, tableKey, columnKey) { |
There was a problem hiding this comment.
Function save has 26 lines of code (exceeds 25 allowed). Consider refactoring.
| tableMetadata: [], | ||
| }; | ||
|
|
||
| render() { |
There was a problem hiding this comment.
Function render has 42 lines of code (exceeds 25 allowed). Consider refactoring.
…ted or after a migration.
emtwo
force-pushed
the
emtwo/schema2_admin_controls
branch
from
8c94c5a to
51bb7af
Compare
|
@emtwo , thanks for all your PRs! We've updated a lot of things now that we're Community-driven so - if you're still interested in getting this merged - would you mind rebasing your PRs off master to re-run the CI, as well as updating merge conflicts? We're trying to clean up our PR todo list, so if you're not interested, that's fine - we'll close the PRs in about a week if we don't hear back. If you're interested in reopening any of the PRs afterwards, we would also very much welcome that. |
This is a fresh PR with the code from #3193 rebased and linted.
It is ready for review now. This PR is the second a part of a series of PRs for schema enhancements.
It is preceded by #3291
[1] Schema viewer drawer #3291
[2] Schema admin configuration #3292 (this one)
[3] Schema query samples #3293
[4] Data source descriptions #3401