Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seamless redirect when SAML is only authentication option #3314

Closed
wants to merge 0 commits into from
Closed

Add seamless redirect when SAML is only authentication option #3314

wants to merge 0 commits into from

Conversation

mikeclarke
Copy link

For the case where SAML is the only option to authenticate, this changeset avoids rendering the template with the "SAML Login" link and starts the SAML login redirect flow directly. This allows for a seamless login experience without having to render the intermediate page with the single link. Works great for my use case, maybe this is handy for others as well.

@ghost ghost added the in progress label Jan 20, 2019
Copy link
Member

@arikfr arikfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We used to have seamless redirects in the past, but it created two problems:

  1. The user can't logout (because when logging out, you get redirected to the login page, which redirects you to the SSO provider).
  2. With Google Apps, it sometimes created endless redirect loops.

How about we add an environment variable (in redash.settings) to control this behavior?

@mikeclarke
Copy link
Author

Environment variable works for me, what do you prefer - maybe REDASH_SEAMLESS_SSO?

  1. The user can't logout (because when logging out, you get redirected to the login page, which redirects you to the SSO provider).

Would it make sense to add a logged-out view that behaves just like the login page, but without the immediate redirect?

  1. With Google Apps, it sometimes created endless redirect loops.

Hm, not sure how to avoid this.

@arikfr
Copy link
Member

arikfr commented Jan 30, 2019

Environment variable works for me, what do you prefer - maybe REDASH_SEAMLESS_SSO?

If it's going to be only for SAML, then maybe REDASH_SEAMLESS_SAML_SSO?

Would it make sense to add a logged-out view that behaves just like the login page, but without the immediate redirect?

Makes sense. Although if you don't mind the immediate redirect, and it's behind an ENV var, I don't mind merging without it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants