Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to Query list page #3402

Merged
merged 2 commits into from
Feb 5, 2019
Merged

Fixes to Query list page #3402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56c1ac2
Fix link to a query page in queries list
kravets-levko Feb 5, 2019
96ad8b7
Merge branch 'master' into bug/queries-list-wrong-link
kravets-levko Feb 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions client/app/pages/queries-list/QueriesList.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class QueriesList extends React.Component {
{
key: 'archive',
href: 'queries/archive',
title: 'Archive',
title: 'Archived',
icon: () => <Sidebar.MenuIcon icon="fa fa-archive" />,
},
{
Expand All @@ -56,7 +56,7 @@ class QueriesList extends React.Component {
Columns.favorites({ className: 'p-r-0' }),
Columns.custom.sortable((text, item) => (
<React.Fragment>
<a className="table-main-title" href={'dashboard/' + item.slug}>{ item.name }</a>
<a className="table-main-title" href={'queries/' + item.id}>{ item.name }</a>
<QueryTagsControl
className="d-block"
tags={item.tags}
Expand Down
4 changes: 2 additions & 2 deletions client/app/pages/queries-list/QueriesListEmptyState.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ export default function QueriesListEmptyState({ page, searchTerm, selectedTags }
);
case 'my': return (
<div className="tiled bg-white p-15">
<a href="queries/new" className="btn btn-primary btn-sm">Create your first query</a> to populate My Queries
list. Need help? Check out our
<a href="queries/new" className="btn btn-primary btn-sm">Create your first query</a>
{' '}to populate My Queries list. Need help? Check out our{' '}
<a href="https://redash.io/help/user-guide/querying/writing-queries">query writing documentation</a>.
</div>
);
Expand Down