Render LDAP and remote auth login links correctly when multi org mode is enabled. #3530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jezdez
commented
Mar 5, 2019
jezdez
commented
Mar 5, 2019
| @@ -91,18 +90,26 @@ def setUp(self): | |||
| super(TestLogin, self).setUp() | |||
| self.factory.org.set_setting('auth_password_login_enabled', True) | |||
|
|
|||
| @classmethod | |||
There was a problem hiding this comment.
I think those methods are leftovers from a previous iteration of the multi org feature.
jezdez
force-pushed
the
remote_auth-login
branch
from
0b808ab to
4f4b1c3
Compare
|
@arikfr Ready for another look. |
|
@arikfr Ready when you're ready. |
The-Alchemist
pushed a commit
to The-Alchemist/redash
that referenced
this pull request
Jul 17, 2019
… is enabled. (getredash#3530) * Make LDAP auth handler org scoped. * Render LDAP and remote auth login links correctly when multi org mode is enabled.
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
… is enabled. (getredash#3530) * Make LDAP auth handler org scoped. * Render LDAP and remote auth login links correctly when multi org mode is enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
When the multi org feature and remote or LDAP auth is enabled at the same time, the login links on the login landing page aren't correctly rendered since they are not passed the current org slug.
As an aside the LDAP auth handler isn't org scoped for some reason, and it's not clear if this was an oversight or deliberate decision.
Related Tickets & Documents
3044c77 added the URL reversal to login.html and seems to be the culprit of the missing org parameter.