Add global options for data sources. #3558
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This is an implementation (to the best of my understanding) of the suggestion proposed here: #2892 (comment) @arikfr I wasn't 100% clear on what you had in mind for this, so I figured I can put up some code to see if we're on the same page.
Essentially there is another
global_options
field that is added to a data source. It behaves very similarly tooptions
except it applies to all data sources, it's not encrypted, and there is an extension pointadd_global_option()
which can be used by extensions to easily add more of these options.Related Tickets & Documents
Discussion for this started here: #2892
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Global options are added to the bottom of the data source page and look the same as the other options (this one has a doc url at the bottom as an example)