Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global options for data sources. #3558

Closed
wants to merge 1 commit into from

Conversation

emtwo
Copy link

@emtwo emtwo commented Mar 8, 2019

What type of PR is this? (check all applicable)

  • Feature

Description

This is an implementation (to the best of my understanding) of the suggestion proposed here: #2892 (comment) @arikfr I wasn't 100% clear on what you had in mind for this, so I figured I can put up some code to see if we're on the same page.

Essentially there is another global_options field that is added to a data source. It behaves very similarly to options except it applies to all data sources, it's not encrypted, and there is an extension point add_global_option() which can be used by extensions to easily add more of these options.

Related Tickets & Documents

Discussion for this started here: #2892

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

screen shot 2019-03-08 at 11 04 30 am

Global options are added to the bottom of the data source page and look the same as the other options (this one has a doc url at the bottom as an example)

@emtwo emtwo force-pushed the emtwo/datasource_options branch from 947eda3 to 9979101 Compare March 11, 2019 20:07
@emtwo emtwo requested review from ranbena and removed request for gabrieldutra March 11, 2019 20:21
@wlach wlach added Leave Open Old, but leave open for now and removed Leave Open Old, but leave open for now labels Jul 17, 2023
@guidopetri
Copy link
Contributor

@emtwo , same story as the other PR - thanks so much! We've updated a lot of things now that we're Community-driven so - if you're still interested in getting this merged - would you mind rebasing off master to re-run the CI, as well as updating merge conflicts?

We're trying to clean up our PR todo list, so if you're not interested, that's fine - we'll close the PR in about a week if we don't hear back. If you're interested in reopening the PR afterwards, we would also very much welcome that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants