allowing to specify a custom work group for AWS Athena queries #3592
Conversation
ghost
added
the
There was a problem hiding this comment.
Thanks @ialeinikov! Could you provide more info on how this was tested on your end?
| @@ -78,6 +78,11 @@ def configuration_schema(cls): | |||
| 'type': 'boolean', | |||
| 'title': 'Use Glue Data Catalog', | |||
| }, | |||
| 'work_group': { | |||
There was a problem hiding this comment.
Could you add this to the correct place in order? (it happens now automatically due to the alphabetical order, but who knows what will come next)
| 'work_group': { | ||
| 'type': 'string', | ||
| 'title': 'Athena work group', | ||
| 'default': 'primary' |
There was a problem hiding this comment.
Wouldn't it be safer/more backward compatible to just not pass anything if no value provided?
There was a problem hiding this comment.
According to the AWS documentation:
By default, each account has a primary workgroup and the default permissions allow all authenticated users access to this workgroup. The primary workgroup cannot be deleted.
redash/query_runner/athena.py
Outdated
| @@ -78,6 +78,11 @@ def configuration_schema(cls): | |||
| 'type': 'boolean', | |||
| 'title': 'Use Glue Data Catalog', | |||
| }, | |||
| 'work_group': { | |||
| 'type': 'string', | |||
| 'title': 'Athena work group', | |||
There was a problem hiding this comment.
| 'title': 'Athena work group', | |
| 'title': 'Athena Work Group', |
|
@rauchy, this was tested on our STG instance of Redash with Athena connections. |
|
@ialeinikov great! Have you given PyAthena a sanity check to make sure nothing breaks? (I'm referring to this change) |
|
@rauchy, yes, we run redash on that version in our stg without any issues. Moreover, we have some Airflow workloads which uses the updated version of 1.5.0 without issues. |
|
Thanks! |
…dash#3592) * allowing to specify a custom work group for AWS Athena queries * Fixing title + adding correct position in the UI
What type of PR is this? (check all applicable)
Description
This change allows specifying a custom AWS Athena work group.
Related Tickets & Documents
https://docs.aws.amazon.com/athena/latest/ug/workgroups.html
Mobile & Desktop Screenshots/Recordings (if there are UI changes)