-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widget drag tests #3598
Merged
Merged
Widget drag tests #3598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amazing. I'm really curious to see how these tests will hold when you do the refactor to React. 🤞 |
@ranbena is on fire 🔥 |
ranbena
commented
Mar 18, 2019
ranbena
force-pushed
the
widget-tests
branch
2 times, most recently
from
March 23, 2019 09:57
7b8d703
to
74bb956
Compare
ghost
added
the
in progress
label
Mar 23, 2019
gabrieldutra
approved these changes
Mar 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really interesting assertions 👍. Only naming suggestions.
Will wait with landing until #3622 |
Co-Authored-By: ranbena <ranbena@gmail.com>
Co-Authored-By: ranbena <ranbena@gmail.com>
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Widget dragging.