Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget drag tests #3598

Merged
merged 6 commits into from
Mar 25, 2019
Merged

Widget drag tests #3598

merged 6 commits into from
Mar 25, 2019

Conversation

ranbena
Copy link
Contributor

@ranbena ranbena commented Mar 17, 2019

What type of PR is this?

  • Other - Tests

Description

Widget dragging.

Screen Shot 2019-03-23 at 15 15 38

@arikfr
Copy link
Member

arikfr commented Mar 17, 2019

Amazing.

I'm really curious to see how these tests will hold when you do the refactor to React. 🤞

@gabrieldutra
Copy link
Member

@ranbena is on fire 🔥

@ranbena ranbena force-pushed the widget-tests branch 2 times, most recently from 7b8d703 to 74bb956 Compare March 23, 2019 09:57
@ranbena ranbena changed the base branch from widget-tests to master March 23, 2019 12:30
@ranbena ranbena changed the title Widget drag tests Widget drag tests (wip) Mar 23, 2019
@ghost ghost added the in progress label Mar 23, 2019
@ranbena ranbena changed the title Widget drag tests (wip) Widget drag tests Mar 23, 2019
Copy link
Member

@gabrieldutra gabrieldutra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really interesting assertions 👍. Only naming suggestions.

cypress/integration/dashboard/dashboard_spec.js Outdated Show resolved Hide resolved
cypress/integration/dashboard/dashboard_spec.js Outdated Show resolved Hide resolved
@ranbena
Copy link
Contributor Author

ranbena commented Mar 23, 2019

Will wait with landing until #3622

@ranbena ranbena merged commit 0995dfb into master Mar 25, 2019
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
@guidopetri guidopetri deleted the drag-tests branch July 22, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants