Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed installation dependencies, instructions #36

Merged
merged 2 commits into from
Nov 7, 2013
Merged

Fixed installation dependencies, instructions #36

merged 2 commits into from
Nov 7, 2013

Conversation

shayelkin
Copy link
Contributor

  • rd_ui/package.json:
    • Add missing bower, grunt-cli dependencies
    • Take grunt from HEAD, as 0.4.1 has broken dependency: gruntjs/grunt@08a3af5
  • README.md:
    • Update instructions

* rd_ui/package.json:
  * Add missing bower, grunt-cli dependencies
  * Take grunt from HEAD, as 0.4.1 has broken dependency: gruntjs/grunt@08a3af5

* README.md:
  * Update instructions
@@ -5,7 +5,7 @@
"grunt-karma": "~0.6.1"
},
"devDependencies": {
"grunt": "~0.4.1",
"grunt": "git+https://github.com/gruntjs/grunt.git",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's worth leaving like this. Because probably in a day or so they will release this version, but we will forever forget to update :-)

@shayelkin
Copy link
Contributor Author

Would this be better? (Take grunt HEAD from the specific fix)
Or do you want to keep this open until grunt 0.4.2 proper is out?

arikfr added a commit that referenced this pull request Nov 7, 2013
Fixed installation dependencies, instructions
@arikfr arikfr merged commit 8177cfe into getredash:master Nov 7, 2013
christophervalles referenced this pull request in hailocab/redash May 8, 2014
Fixed installation dependencies, instructions
washort pushed a commit to washort/redash that referenced this pull request Feb 22, 2017
washort pushed a commit to washort/redash that referenced this pull request Mar 8, 2017
washort pushed a commit to washort/redash that referenced this pull request Mar 22, 2017
washort pushed a commit to washort/redash that referenced this pull request Apr 7, 2017
washort pushed a commit to washort/redash that referenced this pull request Dec 8, 2017
washort pushed a commit to washort/redash that referenced this pull request Dec 13, 2017
washort pushed a commit to washort/redash that referenced this pull request Jan 8, 2018
washort pushed a commit to washort/redash that referenced this pull request Jan 9, 2018
washort pushed a commit to washort/redash that referenced this pull request Apr 30, 2018
washort pushed a commit to washort/redash that referenced this pull request May 31, 2018
washort pushed a commit to washort/redash that referenced this pull request Aug 11, 2018
alison985 pushed a commit to StantonVentures/redash that referenced this pull request Aug 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants