Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Results fails to use query which has double quotes in column names #3618

Merged
merged 2 commits into from
Mar 21, 2019
Merged

Query Results fails to use query which has double quotes in column names #3618

merged 2 commits into from
Mar 21, 2019

Conversation

kravets-levko
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Bug Fix

Description

If source query contains column with double quote (") - Query Results fails to build temporary table with "Syntax error" message.

@kravets-levko kravets-levko self-assigned this Mar 21, 2019
@kravets-levko kravets-levko requested review from arikfr and rauchy March 21, 2019 10:43
@ghost ghost added the in progress label Mar 21, 2019
Copy link
Contributor

@rauchy rauchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. How about a test for this?

@kravets-levko
Copy link
Collaborator Author

@rauchy I tested manually 😄 But being serious - you're right, I'll add some.

@kravets-levko kravets-levko requested a review from rauchy March 21, 2019 11:42
@kravets-levko kravets-levko merged commit 4e69b73 into getredash:master Mar 21, 2019
@ghost ghost removed the in progress label Mar 21, 2019
@kravets-levko kravets-levko deleted the fix/query-results-double-quotes branch March 21, 2019 17:39
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants