Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated Textbox edit dialog to React #3632

Merged
merged 5 commits into from
Mar 26, 2019
Merged

Migrated Textbox edit dialog to React #3632

merged 5 commits into from
Mar 26, 2019

Conversation

ranbena
Copy link
Contributor

@ranbena ranbena commented Mar 24, 2019

What type of PR is this?

  • Refactor

Description

Renamed AddTextboxDialog to TextboxDialog and adjusted to accept this.props.text.
Notice there are already e2e tests that verify textbox add and edit 🏋

Mobile & Desktop Screenshots/Recordings

Before:

After:

@ranbena ranbena requested a review from kravets-levko March 24, 2019 12:37
@ranbena
Copy link
Contributor Author

ranbena commented Mar 26, 2019

@kravets-levko can you give this a quick look?
I split it into 2 commits for review convenience.

@ranbena ranbena merged commit 8230098 into master Mar 26, 2019
@ranbena ranbena deleted the txt-edit branch March 26, 2019 17:23
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
@ranbena @harveyrendell
Migrated Textbox edit dialog to React (getredash#3632)
6e818f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kravets-levko kravets-levko kravets-levko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ranbena @kravets-levko