Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker compose with the stable Redash v7 tag #3638

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Update docker compose with the stable Redash v7 tag #3638

merged 1 commit into from
Mar 25, 2019

Conversation

justinclift
Copy link
Member

What type of PR is this? (check all applicable)

  • 1-liner trivial update

@justinclift
Copy link
Member Author

Hmmm, the hard coded PostgreSQL version in the file is a cause for concern too. It's literally behind by 10 patch revisions, including security updates.

I'll submit an updated PR with that fixed shortly.

@arikfr arikfr merged commit 1d7378f into getredash:master Mar 25, 2019
@arikfr
Copy link
Member

arikfr commented Mar 25, 2019

Thanks, @justinclift ! About Postgres: you're right. We just need to keep the major version.

@justinclift justinclift deleted the v7-compose branch March 25, 2019 12:51
@justinclift
Copy link
Member Author

No worries. Just submitted a PR with the change. In theory (!) it shouldn't have any negative effect, and in quick testing locally here with a newly built VM for Redash using it, it was ok. But, lets see if the tests for the PR pass.

The Redis version (v3.0) may also be a concern. Looking at the Docker Hub, the oldest release series listed is v4:

    https://hub.docker.com/_/redis

I'll experiment with it a bit here, and see how badly things break with that. 😉

@justinclift
Copy link
Member Author

Redis 5 seems to work as a drop-in replacement. Just updated the semi-production box here with it, and everything is working fine.

@arikfr
Copy link
Member

arikfr commented Mar 27, 2019

Redis 5 seems to work as a drop-in replacement. Just updated the semi-production box here with it, and everything is working fine.

My concern with using a newer version of Redis in our Docker Compose setup is that people might use newer features that are not supported in Redis 3, which is what most deployments have.

How about we update the setup docker compose but keep the dev one as is?

@justinclift
Copy link
Member Author

justinclift commented Mar 27, 2019

That concern makes sense to me. I'm not (yet) sure of the difference between the "setup docker compose" vs the dev one though.

I'll prob look into it a bit tomorrow. About to hit the sack here now. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants