Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Percy diff due to Api Key secret #3654

Merged
merged 1 commit into from
Mar 29, 2019
Merged

Conversation

gabrieldutra
Copy link
Member

What type of PR is this? (check all applicable)

  • Bug Fix?
  • Other

Description

This one passed unnoticed after #3450 since a visual diff was expected to the page. Groups were added to the UserEdit page and as they require a new load, the content was rendered again before Percy snapshot (the Api Key was also rendered again with it). To fix this the screenshot is now taken Right after changing the input value.

Related Tickets & Documents

--

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

--

@gabrieldutra gabrieldutra self-assigned this Mar 28, 2019
@gabrieldutra gabrieldutra merged commit 12782e4 into master Mar 29, 2019
@gabrieldutra gabrieldutra deleted the fix-percy-api-key branch July 4, 2019 17:54
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants