Update CardsList to use visual-card styling #3679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranbena
reviewed
Apr 7, 2019
ranbena
approved these changes
Apr 8, 2019
|
👍 |
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
* Update CardsList to use old markup * CR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This updates Sources pages to use old TypePicker markup (#3677).
Differences from old markup implementation:
onClickevent. Small issue with it: the margin is inside<a>, so you can click in the space between cards. (It didn't seem a big issue to me, but LMK what you think)Related Tickets & Documents
#3677
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Old View (to be compared)
This PR
