Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package-lock.json after including qs #3695

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Add package-lock.json after including qs #3695

merged 1 commit into from
Apr 10, 2019

Conversation

rauchy
Copy link
Contributor

@rauchy rauchy commented Apr 10, 2019 •
edited by kravets-levko
Loading

What type of PR is this? (check all applicable)

  • Bug Fix

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@rauchy rauchy requested a review from arikfr April 10, 2019 07:23
@kravets-levko kravets-levko changed the title add package.json after including qs Add package-lock.json after including qs Apr 10, 2019
@kravets-levko
Copy link
Collaborator

@rauchy I see that npm installed qs of the same version few times. Usually it happens when you add dependency to the project, but one of existing dependencies already have it. Try to remove node_modules, run npm install and see if it helps to remove duplicates.

@rauchy
Copy link
Contributor Author

rauchy commented Apr 10, 2019

@kravets-levko that's interesting. I tried doing it and it had no effect though :(

kravets-levko
kravets-levko approved these changes Apr 10, 2019
View reviewed changes
Copy link
Collaborator

@kravets-levko kravets-levko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems other qs are related to webpack-dev-server, so looks fine 👍

@rauchy rauchy merged commit 9fcf510 into master Apr 10, 2019
@rauchy rauchy deleted the package-json-for-qs-dependency branch April 10, 2019 08:26
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
@harveyrendell
add package.json after including qs (getredash#3695)
f3b3801
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kravets-levko kravets-levko kravets-levko approved these changes

@arikfr arikfr Awaiting requested review from arikfr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rauchy @kravets-levko