Dynamic query time limits #3702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
reviewed
Apr 11, 2019
redash/settings/dynamic_settings.py
Outdated
|
|
||
| # Replace this method with your own implementation in case you want to limit the time limit on certain queries or users. | ||
| def get_query_time_limit(is_scheduled, user_id): | ||
| return None if is_scheduled else int_or_none(os.environ.get('REDASH_ADHOC_QUERY_TIME_LIMIT', None)) |
There was a problem hiding this comment.
Let's take this opportunity to introduce a value for scheduled queries as well.
redash/settings/dynamic_settings.py
Outdated
| from .helpers import int_or_none | ||
|
|
||
| # Replace this method with your own implementation in case you want to limit the time limit on certain queries or users. | ||
| def get_query_time_limit(is_scheduled, user_id): |
There was a problem hiding this comment.
I thought we have a User object at hand when calling this. Considering we don't, let's pass in org_id as well (or only org_id?).
There was a problem hiding this comment.
If the purpose of extracting this to a dynamic class was to allow users to customize this according to their needs, I'd say a user_id would allow more cases to be handled. I say we provide both. 5dc5340
arikfr
approved these changes
Apr 15, 2019
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
* extract time limit decisions to a dynamic settings function * introduce environment variable for scheduled query time limits * pass in org_id to query_time_limit * add an interaction test that verifies that time limits are applied to jobs * really important newlines according to CodeClimate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR allows users to define their own custom query time limit decisions by supplying their own function to determine the limit for a adhoc/scheduled query run by a specific user.
Related Tickets & Documents
#3700
Mobile & Desktop Screenshots/Recordings (if there are UI changes)