Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query based parameter has value null when created #3707

Merged
merged 2 commits into from
Apr 29, 2019

Conversation

gabrieldutra
Copy link
Member

What type of PR is this? (check all applicable)

  • Bug Fix

Description

Whenever a new Query Based Parameter was created it started with a null value.

For this I noticed that the prop value starts with null and is updated after some time, the problem is that Antd's defaultValue only sets the value on the first time.

I also took the opportunity to replace componentWillReceiveProps to componentDidUpdate as the first one is deprecated.

Related Tickets & Documents

--

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Before
query-based-parameter-null

After
query-based-parameter-fixed

@gabrieldutra gabrieldutra self-assigned this Apr 13, 2019
Copy link
Collaborator

@kravets-levko kravets-levko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@arikfr arikfr merged commit f3a653c into master Apr 29, 2019
@arikfr arikfr deleted the fix-query-based-parameter-null branch April 29, 2019 18:50
@arikfr
Copy link
Member

arikfr commented Apr 29, 2019

👍

harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
* Fix query based parameter value null when created

* Use toString to avoid having 'null' string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants