add get_by_id to Organization #3712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jezdez
reviewed
Apr 16, 2019
| @classmethod | ||
| def get_by_id(cls, _id): | ||
| return cls.query.filter(cls.id == _id).one() | ||
|
|
There was a problem hiding this comment.
What if we add a custom base model class that has this method (and maybe be other duplicates)?
http://flask-sqlalchemy.pocoo.org/2.3/customizing/#model-class
# in redash/models/base.py
from flask_sqlalchemy import Model
class RedashModel(Model):
@classmethod
def get_by_id(cls, _id):
return cls.query.filter(cls.id == _id).one()
# ...
db = RedashSQLAlchemy(
model_class=RedashModel,
session_options={
'expire_on_commit': False
},
)
There was a problem hiding this comment.
That's a good idea, but a bit out of scope for this PR. Let's keep it in mind for future refactors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)