Code

Failed Scheduled Queries Report#3798

Code

Merged

rauchy merged 67 commits intomastergetredash/redash:masterfrom failed-queries-reportgetredash/redash:failed-queries-reportCopy head branch name to clipboardJul 28, 2019

+258-5

Commits

Commits on May 14, 2019

• initial work on e-mail report for failed queries

  

  Omer Lachish

  committed
  dae6013

• send failure report only for scheduled queries and not for adhoc queries

  

  Omer Lachish

  committed
  ca7e3a2

• add setting to determine if to send failure reports

  

  Omer Lachish

  committed
  b388c6f

• add setting to determine interval of aggregated e-mail report

  

  Omer Lachish

  committed
  e910fd3

• html templating of scheduled query failure report

  

  Omer Lachish

  committed
  e695549

• break line

  

  Omer Lachish

  committed
  13e9bb1

• support timeouts for failure reports

  

  Omer Lachish

  committed
  95be1a9

• aggregate errors within message and warn if approaching threshold

  

  Omer Lachish

  committed
  ba299cd

Commits on May 19, 2019

• Merge branch 'master' into failed-queries-report

  

  Omer Lachish

  committed
  075c2a6

• handle errors in QueryExecutor.run instead of on_failure

  

  Omer Lachish

  committed
  0722195

• move failure report to its own module

  

  Omer Lachish

  committed
  8959688

• indicate that failure count is since last report

  

  Omer Lachish

  committed
  d88e589

• copy changes

  

  Omer Lachish

  committed
  5adb58e

• format with <code>

  

  Omer Lachish

  committed
  db6086f

• styling, copy and add a link to the query instead of the query text

  

  Omer Lachish

  committed
  b90d673

• separate reports with <hr>

  

  Omer Lachish

  committed
  ac9e896

• switch to UTC

  

  Omer Lachish

  committed
  4e1ffe5

• move <h2> to actual e-mail subject

  

  Omer Lachish

  committed
  66cea95

• add explicit message for SoftTimeLimitExceeded

  

  Omer Lachish

  committed
  6e20846

• fix test to use soft time limits

  

  Omer Lachish

  committed
  eb8275c

• default query failure threshold to 100

  

  Omer Lachish

  committed
  6ba466f

• use base_url from utils

  

  Omer Lachish

  committed
  8767011

• newlines. newlines everywhere.

  

  Omer Lachish

  committed
  045789d

• remove redundant import

  

  Omer Lachish

  committed
  6f3c426

Commits on May 21, 2019

• apply new design for failure report

  

  Omer Lachish

  committed
  abe6a36

• use jinja to format the failure report

  

  Omer Lachish

  committed
  a2072b6

• don't show comment block if no comment is provided

  

  Omer Lachish

  committed
  102c1e7

• don't send emails if, for some reason, there are no available errors

  

  Omer Lachish

  committed
  04458be

• subtract 1 from failure count, because the first one is represented by 'Last failed'

  

  Omer Lachish

  committed
  4770c43

• don't show '+X more failures' if there's only one

  

  Omer Lachish

  committed
  5011198

• extract subject to variable

  

  Omer Lachish

  committed
  7fe20ea

• format as text, while we're at it

  

  Omer Lachish

  committed
  9c38f3d

• allow scrolling for long exception messages

  

  Omer Lachish

  committed
  b61b7eb

• test that e-mails are scheduled only when beneath limit

  

  Omer Lachish

  committed
  90d14ad

• test for indicating when approaching report limits + refactor

  

  Omer Lachish

  committed
  d504c2b

• test that failures are aggregated

  

  Omer Lachish

  committed
  90c6a30

• test that report counts per query and reason

  

  Omer Lachish

  committed
  f539bee

• test that the latest failure occurence is reported

  

  Omer Lachish

  committed
  6b6bc0e

• force sending reports for testing purposes

  

  Omer Lachish

  committed
  3f40de8

Commits on May 22, 2019

• Update redash/templates/emails/failures.html

  Show description for 99ed585
  

  Omer Lachish

  and

  ranbena

  authored
  99ed585

• Update redash/templates/emails/failures.html

  Show description for 722f7d2
  

  Omer Lachish

  and

  ranbena

  authored
  722f7d2

• Update redash/tasks/failure_report.py

  

  Omer Lachish

  authored
  a08a249

Commits on May 27, 2019

• Merge branch 'master' into failed-queries-report

  

  Omer Lachish

  committed
  bfdccb4

Commits on May 30, 2019

• Merge branch 'master' into failed-queries-report

  

  Omer Lachish

  committed
  d4d51dd

Commits on May 31, 2019

• add org setting for email reports

  

  Omer Lachish

  committed
  3a281ba

Commits on Jun 2, 2019

• Merge branch 'failed-queries-report' of github.com:getredash/redash into failed-queries-report

  

  Omer Lachish

  committed
  85a319e

Commits on Jun 10, 2019

• Merge branch 'master' into failed-queries-report

  

  Omer Lachish

  committed
  5e5e456

• remove logo from failure report email

  

  Omer Lachish

  committed
  6ff0962

Commits on Jul 14, 2019

• Merge branch 'master' into failed-queries-report

  

  Omer Lachish

  committed
  9215c70

Commits on Jul 18, 2019

• Merge branch 'master' into failed-queries-report

  

  Omer Lachish

  committed
  5043b5b

Commits on Jul 20, 2019

• Merge branch 'master' into failed-queries-report

  

  Omer Lachish

  committed
  6db4803

• correctly use the organization setting for sending failure reports

  

  Omer Lachish

  committed
  57515ef

• use user id as key for failure reports data structure

  

  Omer Lachish

  committed
  0bfe9f4

• Update redash/tasks/failure_report.py

  Show description for 72fb0b1
  

  Omer Lachish

  and

  arikfr

  authored
  72fb0b1

• build comments while creating context for e-mail templates

  

  Omer Lachish

  committed
  8182365

• Merge branch 'failed-queries-report' of github.com:getredash/redash into failed-queries-report

  

  Omer Lachish

  committed
  cdd72b6

• figure out the base url when creating the e-mail

  

  Omer Lachish

  committed
  4e80124

• no need to expire pending failure report keys as they are deleted anyway when sent

  

  Omer Lachish

  committed
  8333e25

• a couple of CodeClimate changes

  

  Omer Lachish

  committed
  688b216

• refactor key creationg to a single location

  

  Omer Lachish

  committed
  bafe782

• refactor tests to send e-mail from a single function

  

  Omer Lachish

  committed
  2275d31

Commits on Jul 21, 2019

• use beat to schedule a periodic send_aggregated_errors task instead of using countdown per email

  

  Omer Lachish

  committed
  2fb4882

• remove pending key as it is no longer required when a periodic task picks up the reports to send

  

  Omer Lachish

  committed
  6f0066e

• a really important blank line. REALLY important.

  

  Omer Lachish

  committed
  c7d8ed8

• Revert "a really important blank line. REALLY important."

  Show description for a989c25
  

  Omer Lachish

  committed
  a989c25

• a really important blank line. REALLY important. It is the best blank line.

  

  Omer Lachish

  committed
  4a95817

Commits on Jul 25, 2019

• don't send failure emails to disabled users

  

  Omer Lachish

  committed
  7b232be