Plug custom Celery tasks via dynamic settings #3819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
approved these changes
May 22, 2019
|
Huh, that's a new twist on the extension problem, we have had extensible periodic tasks for a while until they were removed in #3465. Would you say the overlap is okay keeping given dynamic settings are more deployment specific and not particularly tied to extensions? That reminds me @arikfr I just saw your last comment in #3569 about the requirements file added there. Merging this would go a long way to a better separation of App and Worker code. |
|
IOW, I'm very much interested in solving #3466 still. |
|
Okay, understood, thanks for clarification! |
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
* plug custom celery tasks via dynamic settings * an extra blank line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This would allow users to provide their own custom tasks to run periodically.