Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include BigQueryGCE into default query runners #3822

Closed
wants to merge 2 commits into from

Conversation

rueian
Copy link
Contributor

@rueian rueian commented May 22, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

include big_query_gce into default_query_runners
include bigquery_gce.png into db-logos

Related Tickets & Documents

#3356

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

before:

image

after:

image

@rueian rueian changed the title Bigquery gce default runner Include BigQueryGCE into default query runners May 22, 2019
Copy link
Member

@arikfr arikfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rueian, but BigQuery GCE is not enabled by default for a reason. I don't mind merging in the icon, but please remove it from the default_query_runners list.

If you need it in your environment, it's easy to enable non default query runners via settings.

@rueian
Copy link
Contributor Author

rueian commented May 23, 2019

Thanks, I will create another PR for the missing icon.

And may I ask the reason why BigQuery GCE is not enabled by default? Will it be removed soon?

It was just suddenly disappeared after upgrading redash to v7.0.0, and took me a while to find out how it was disappeared.

Maybe we can add some documentation about this?

@arikfr
Copy link
Member

arikfr commented May 29, 2019

And may I ask the reason why BigQuery GCE is not enabled by default? Will it be removed soon?

Its enabled check was sometimes causing issues when trying to start Redash and because it's not commonly used, it was simpler to remove from the default list.

There are no plans to remove it at the moment.

Maybe we can add some documentation about this?

Good idea! The documentation is in the website repo.

@arikfr arikfr closed this May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants