Fix table isn't displayed with date filter

[gabrieldutra]

What type of PR is this? (check all applicable)

• Bug Fix

Description

Fix for #3836

Related Tickets & Documents

Fixes #3836

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Filter

Multifilter

[gabrieldutra]

@arikfr there are two commits of mine:

• First one - fix the issues I found using String to compare objects
• Second one - implements my idea of using the keys

Comparing keys approach with the string one, the good part is that it uses Moment values for comparison, thus it's more reliable. Also if another type of value appear in the future the string approach may not cover it. The con I see is that I had to introduce the { key, label } syntax from Antd select's labelInValue because I couldn't define the value otherwise, this made this fix a bit more complex.

So, lmk what you prefer.

[kravets-levko]

@gabrieldutra There is some issue with searching values in filter's dropdown - when I open dropdown and try to type something in the input - it sometimes shows matching filter values, and sometimes not (but I know that there are values matching my input).

[kravets-levko]

@gabrieldutra BTW - Select.Option has two attributes: key and value. key can be only string or number, but value can be anything. If value is present, Select will use it instead of key. I think you can use it for "raw" values (and put formatted as Option's content) - it should simplify your code and fix search.

[gabrieldutra]

Thanks for point this out @kravets-levko.

The issue with the search is that it works on the value || key attr by default, it will be necessary to modify the filterOption prop with a search function 😪

Select.Option has two attributes: key and value. key can be only string or number, but value can be anything

I'd tried that with value, it does "allow" you to send raw values, but it has a propType warning:

.

I wouldn't trust Ant internal API to handle those values without errors internally (e.g: on search)

[arikfr]

LGTM. @kravets-levko wdyt?

[kravets-levko]

Thanks! 🎉

[gabrieldutra]

It seems that Percy still has some weird diffing, at least it became rare. Well, that one looks normal both local and on Preview 🙂

[arikfr]

Good to go? :)

[denisov-vlad]

Thanks.

But I think that DATE column should be without hours and minutes. It looks a little bit noisy in multifilter.

[arikfr]

@denisov-vlad while I agree, it felt like a reasonable compromise for now. Would you mind opening an issue for this, so we don't forget to address it?