Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force a Choose account step for Google OAuth #3884

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

kravets-levko
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Other

Description

Force show a Choose account step for Google OAuth (previously this feature didn't work for me - I have two accounts, and it was using only active (default? most recently used?) one). Small side-effect: with this fix it will show Choose account step even if there is the only account available (probably not a big deal - at least, users will be 100% sure which account will be used).

@kravets-levko kravets-levko requested review from arikfr and rauchy June 6, 2019 10:47
@kravets-levko kravets-levko self-assigned this Jun 6, 2019
Copy link
Contributor

@rauchy rauchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know if most users have 1 account or more, but I guess adding another click for everyone is a reasonably fair price to pay in order to have multiple-account users being able to log in. 👍

@arikfr arikfr merged commit 7a9f4b0 into master Jun 12, 2019
@arikfr arikfr deleted the google-oauth-force-choose-account branch June 12, 2019 08:48
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants