Query Results: querying a column with a dictionary or array fails #3887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
…tredash#3887) * flatten lists and dicts to json to be used with SQLite's json_extract functions * add test that verifies that lists and dicts are saved * add test that verifies that lists and dicts are saved
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Summary
When using the Query Results data source to query from a query result that one of the columns if of type dictionary of array, it fails with a cryptic message.
Steps to Reproduce
Example query: https://redash-preview.netlify.com/queries/154/source. When you execute it you get:
For starters, we should show a friendlier message, explaining which column had this issue.
As an improved behavior we can convert the value into JSON, so the user can further query it using SQLite's JSON functions.